<html>
<head><meta charset="utf-8"><title>Struggling with reviewing PRs in time · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html">Struggling with reviewing PRs in time</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="229476765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229476765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229476765">(Mar 09 2021 at 13:34)</a>:</h4>
<p>In the recent weeks I struggle to get in my reviews in a timely manner. So if people have time to review a little bit more, feel free to pick up <a href="https://github.com/pulls?q=is%3Aopen+is%3Apr+assignee%3Aflip1995+archived%3Afalse+">some PRs from me</a>. (Also if you're not a team member, but want to get involved in reviewing Clippy PRs, just ping me, that you want to review a PR and I can give you a good-first-review PR.)</p>
<p><span class="user-mention" data-user-id="369415">@xFrednet</span> already waits on a review of <a href="https://github.com/rust-lang/rust-clippy/issues/6463">clippy#6463</a> for a few weeks, which is a great, but pretty big PR. If someone wants to pick this up, please do!</p>



<a name="229483763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229483763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yoshitomo Nakanishi <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229483763">(Mar 09 2021 at 14:20)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span>  I want to review a PR!</p>



<a name="229484735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229484735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229484735">(Mar 09 2021 at 14:26)</a>:</h4>
<p><span class="user-mention" data-user-id="275569">@Yoshitomo Nakanishi</span> Almost gave you your own PR <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span> Anyway, this PR should be a good review: <a href="https://github.com/rust-lang/rust-clippy/issues/6831">clippy#6831</a></p>



<a name="229485147"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229485147" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yoshitomo Nakanishi <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229485147">(Mar 09 2021 at 14:29)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> Thanks! I'll review that and notify you when finish the review.</p>



<a name="229486644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229486644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229486644">(Mar 09 2021 at 14:38)</a>:</h4>
<p>I can take one</p>



<a name="229486878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229486878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229486878">(Mar 09 2021 at 14:40)</a>:</h4>
<p>You know it's going too long when the submitter puts a <span aria-label="thumbs down" class="emoji emoji-1f44e" role="img" title="thumbs down">:thumbs_down:</span> on all the merge conflict messages <span aria-label="laughter tears" class="emoji emoji-1f602" role="img" title="laughter tears">:laughter_tears:</span></p>



<a name="229487033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229487033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229487033">(Mar 09 2021 at 14:41)</a>:</h4>
<p><span class="user-mention" data-user-id="360405">@Cameron Steffen</span> <a href="https://github.com/rust-lang/rust-clippy/issues/6706">clippy#6706</a></p>



<a name="229492473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229492473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229492473">(Mar 09 2021 at 15:15)</a>:</h4>
<p>I could also take one :) Feeling a bit more on top of things this month <span aria-label="juggling" class="emoji emoji-1f939" role="img" title="juggling">:juggling:</span></p>



<a name="229492729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229492729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229492729">(Mar 09 2021 at 15:17)</a>:</h4>
<p>Thanks everyone!</p>
<p><span class="user-mention" data-user-id="197894">@Philipp Hansch</span> If you're ok to take a bigger one, it would be great if you could take up <a href="https://github.com/rust-lang/rust-clippy/issues/6463">clippy#6463</a> . Otherwise just pick any PR assigned to me <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="229493060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/229493060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#229493060">(Mar 09 2021 at 15:19)</a>:</h4>
<p>I will give the big one a try <span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span></p>



<a name="231464548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/231464548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#231464548">(Mar 23 2021 at 12:56)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> If you haven't seen this yet, can I review this? <a href="https://github.com/rust-lang/rust-clippy/pull/6905">https://github.com/rust-lang/rust-clippy/pull/6905</a></p>



<a name="231464712"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Struggling%20with%20reviewing%20PRs%20in%20time/near/231464712" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Struggling.20with.20reviewing.20PRs.20in.20time.html#231464712">(Mar 23 2021 at 12:57)</a>:</h4>
<p>Yeah, sure that would be great! I saw you already started, so go ahead!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>